Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CI target for functional tests and related vars #931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding CI target for functional tests and related vars #931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ SHELL = /usr/bin/env bash -o pipefail
# Extra vars which will be passed to the Docker-build
DOCKER_BUILD_ARGS ?=

# Ginkgo args
GINKGO_REPEAT = --repeat 5
GINKGO_RAND_ALL = --randomize-all
GINKGO_CI_ARGS ?= $(GINKGO_REPEAT) $(GINKGO_RAND_ALL) --no-color

.PHONY: all
all: build

Expand Down Expand Up @@ -170,6 +175,10 @@ golangci-lint:
.PHONY: test
test: manifests generate gowork fmt vet envtest ginkgo ginkgo-run ## Run ginkgo tests with dependencies.

.PHONY: test-ci
test-ci: GINKGO_ARGS = $(GINKGO_CI_ARGS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a new target for this? can't we just set different GINKGO_ARGS in the CI job?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my original suggestion. But it was pointed out that we would have to submit PR to release repo every time we would want to change anything about the way ginkgo runs, say number of repetitions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, so maybe we should get some review of those who requested it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are on the list.

test-ci: manifests generate gowork fmt vet envtest ginkgo ginkgo-run ## Run ginkgo tests with dependencies.

.PHONY: ginkgo-run
ginkgo-run: ## Run ginkgo.
source hack/export_related_images.sh && \
Expand Down