Use crd-to-adoc instead of crd-to-markdown #866
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/test all |
|
/test precommit-check |
|
/test openstack-operator-build-deploy-kuttl |
|
/test openstack-operator-build-deploy-kuttl |
1 similar comment
|
/test openstack-operator-build-deploy-kuttl |
| .PHONY: crd-to-adoc | ||
| crd-to-adoc: $(CRD_ASCIIDOC) ## Download crd-to-adoc locally if necessary. | ||
| $(CRD_ASCIIDOC): $(LOCALBIN) | ||
| test -s $(LOCALBIN)/crd-to-adoc || GOBIN=$(LOCALBIN) go install github.com/fao89/crd-to-adoc@$(CRD_ASCIIDOC_VERSION) |
There was a problem hiding this comment.
are we expecting to maintain this lib ? I'm wondering if we want to build a module in lib-common and promote it under the osp-k8s-operators umbrella.
I'd like to clarify this point before moving forward.
There was a problem hiding this comment.
crd-to-markdown last commit was 3 years ago,
I believe it is a low-maintenance thing so I forked it.
I'm ok to maintain the fork, but moving to lib-common sounds good
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a2538b7c617e48c689a0274787023d44 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 28m 14s |
|
recheck |
|
/test openstack-operator-build-deploy-kuttl |
Signed-off-by: Fabricio Aguiar <[email protected]>
https://github.com/fao89/crd-to-adoc
https://logserver.rdoproject.org/66/866/9038e7e0b1bc7e0752b9fe7e0f389f9e09aa789d/github-check/openstack-operator-docs-preview/760aec0/docs_build/docs_build/openstack/ctlplane-upstream.html