Implementing sending retrieving data #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit implements all the workflow logic for sending data and receiving the history. It however does not implement converting Json data of multimedia data to an input stream
Add non-functional implementations of SenderTransferDao and RecieverTransferDao
- Retry sending manifest if it fails for a max of 2 times - Add SyncSenderHandler tests
- This adds a SyncReceiverHandler which handles the received manifests and their respective paylods
This also enables receiving another data payload while the last is still being processed by the host application
- Inform the receiver that the transfer is complete - Disconnect after the message is received by the receiver - Reset the connection in case of an error Fixes #16
1. Fix saving of record history 2. Add metadata details to SyncPackageManifest - This will mostly be used by MultiMedia which might not contain required metadata in its 3. Fix conversion of JSONArray to string and from String 4. Fix sequence of data processing where some last records are processed before earlier records in the AsyncTask 5. Implement Sending and Receiving transfer dao in the sample app for testing
- Revert to processing data immediately - Use default batch size as 20
1. Process stream chunks so as to enable the sending end to refill the stream 2. Enable sending of media file record id in payload-details map 3. Fix sending and receiving file payloads on sender and receiver 4. Perform stream sending on background thread 5. Add media sending in sample app
ekigamba
force-pushed
the
issue/10-11-12-14-implementing-sending-retrieving-data
branch
from
e68bba4 to
e27980b
Compare
Log empty else calls that should not be possible
ekigamba
force-pushed
the
issue/10-11-12-14-implementing-sending-retrieving-data
branch
from
7083afc to
ca4ba36
Compare
ekigamba
force-pushed
the
issue/10-11-12-14-implementing-sending-retrieving-data
branch
from
ca4ba36 to
963b8c3
Compare
githengi
approved these changes
May 30, 2019
ekigamba
deleted the
issue/10-11-12-14-implementing-sending-retrieving-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Fixes #11
Fixes #12
FIxes #14
Fixes #35
Fixes #16
Fixes #40
Fixes #42