-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SyncJobStatus result callback amid Sync retries #2049
Closed
Labels
P1
High priority issue
Comments
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this issue
Aug 23, 2023
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this issue
Aug 23, 2023
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this issue
Aug 23, 2023
EDITED by @jingtang10 |
@aditya-07 #2371 are these similar issues? |
closing in favour of #1654 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently, there is no way for reliant apps to obtain the exceptions from backend calls until all Sync retries are completed by the FhirSyncWorker class. Our app would like to process the exceptions as soon as they happen.
Describe the solution you'd like
We'd like to add an abstract method to the
FhirSyncWorker.kt
class that would need to be implemented by the reliant app. It should accept a parameter of typeSyncJobStatus
.For example:
It should then be invoked within the
FhirSyncWorker.doWork
method after the result is obtained.Describe alternatives you've considered
We could also just log the failures in an open method that could be overridden by the reliant app. This way they'd have the ability to obtain the exceptions that are part of the
SyncJobStatus.Failed
instance. The SDK could log those errors in its implementation(as default).For example:
Additional context
N/A
Would you like to work on the issue?
Yes
The text was updated successfully, but these errors were encountered: