Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Zeiss CZI #86

Merged
merged 1 commit into from
May 14, 2024
Merged

Document Zeiss CZI #86

merged 1 commit into from
May 14, 2024

Conversation

bgilbert
Copy link
Member

@openslide-bot
Copy link

openslide-bot commented May 12, 2024

DCO signed off ✔️

All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1.

@bgilbert
Copy link
Member Author

@iewchen Could you take a look and make sure I haven't misstated anything?

@iewchen
Copy link
Contributor

iewchen commented May 13, 2024

czi-format.md

I have made some minor edits. Please see the attached file.

Edit: correct spelling. czi-format.md

@bgilbert
Copy link
Member Author

Updated based on your feedback, thanks. Could you take another look?

I noticed that you dropped the statement that Label and SlidePreview have one subblock of uncompressed pixel data, 24 bpp and 48 bpp respectively. Is that not correct? OpenSlide doesn't enforce the 24bpp/48bpp part but does currently assume those images are single-subblock and uncompressed.

@iewchen
Copy link
Contributor

iewchen commented May 14, 2024

Looks good.

The one subblock of uncompressed pixel data, 24 bpp and 48 bpp are observations, they are not in the CZI specification.

For SlidePreview, other cameras can be used, such as use monochrome camera to capture preview in fluorescence, therefore it may be stored as 16bpp , although I haven't tried.

All Label and SlidePreview I saw so far have only one subblock and are uncompressed. They do not have the scene dimension. The one subblock seems to be a good choice for color images, since their size are less than 2000x2000. I don't quite understand why they are stored as uncompressed.

For openslide/openslide#396.

Co-authored-by: Wei Chen <[email protected]>
Signed-off-by: Wei Chen <[email protected]>
Signed-off-by: Benjamin Gilbert <[email protected]>
@bgilbert
Copy link
Member Author

Got it, thanks. I've dropped the statement.

@bgilbert bgilbert merged commit 4d505d8 into openslide:main May 14, 2024
2 checks passed
@bgilbert bgilbert deleted the czi branch May 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants