Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Pull Request Close #957

Open
chmouel opened this issue Nov 8, 2022 · 2 comments
Open

Handle Pull Request Close #957

chmouel opened this issue Nov 8, 2022 · 2 comments
Labels
providers

Comments

@chmouel
Copy link
Member

chmouel commented Nov 8, 2022

Should we cancel the pipelinerun attached to a pull request when we get a pull request close event?
@sm43
Copy link
Contributor

sm43 commented Nov 9, 2022

yeah may be
if user open the pull req again, it will trigger again
so we can cancel

@chmouel
Copy link
Member Author

chmouel commented Apr 17, 2023

I don't think that's what other CI does tho (ie: github action) i think we should follow what the others do and give the element of least surprise to the user.

@lcarva lcarva mentioned this issue Apr 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
providers
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chmouel @sm43