Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Repository CR for git_provider URL and Improve Docs #803

Closed
sm43 opened this issue Aug 23, 2022 · 3 comments
Closed

Validate Repository CR for git_provider URL and Improve Docs #803

sm43 opened this issue Aug 23, 2022 · 3 comments

Comments

@sm43
Copy link
Contributor

sm43 commented Aug 23, 2022

https://coreos.slack.com/archives/C0382KN768J/p1661246439581249
@chmouel
Copy link
Member

chmouel commented Sep 28, 2022

can we add more context without being behind (closed) slack, please 🙏🏻

@sm43
Copy link
Contributor Author

sm43 commented Sep 28, 2022

this has been fixed now.. this was about gitlab.com
if giturl was not added in repo CR it used to fail request
now its documented so we can close this for now

@sm43 sm43 closed this as completed Sep 28, 2022
@chmouel
Copy link
Member

chmouel commented Sep 28, 2022

i think it's not really fixed, we still need to fix it properly i.e: #828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chmouel @sm43