Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment on pull request when a non collaborator submit a pull request #1343

Open
chmouel opened this issue Jun 30, 2023 · 2 comments
Open

Comments

@chmouel
Copy link
Member

chmouel commented Jun 30, 2023

When a non collaborator user submit a pull request instead of being completely quiet about it we can add a comment letting know the user waiting for some collaborator to issue a /ok-to-test

an example of how prow message look like :

Hi username. Thanks for your PR.

I'm waiting for a [tektoncd](https://github.com/orgs/tektoncd/people) member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://github.com/orgs/tektoncd/people) to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=tektoncd%2Fpipeline).

cc @sm43 :)

@sm43
Copy link
Contributor

sm43 commented Jun 30, 2023

would this be additional to the checkrun we create or we skip creating the checkrun?

@chmouel
Copy link
Member Author

chmouel commented Jun 30, 2023

I don't think a checkrun will be created since people has been explicitly not wanting that and that's not how prow works too..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants