Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve auto-keep-alive mechanism inside the OpenSergoClient #17

Open
sczyh30 opened this issue Dec 2, 2022 · 0 comments
Open

Improve auto-keep-alive mechanism inside the OpenSergoClient #17

sczyh30 opened this issue Dec 2, 2022 · 0 comments
Labels
kind/enhancement Category issues or PRs related to enhancement

Comments

@sczyh30
Copy link
Member

sczyh30 commented Dec 2, 2022

Issue Description

Type: feature request

Describe what feature you want

Improve auto-keep-alive mechanism inside the OpenSergoClient.

(details TBD)


目前 OpenSergoClient 具备自动的 keep-alive 机制,其底层是通过一个巡检 goroutine 实现。这里面会有一些问题:

  • keep-alive task 由初次 Start() 发起,这里面就会有一种比较奇怪的情况:即由于网络抖动问题,client stream 建立失败,Start 返回 error;但内部的 keep-alive task 重试几次后可能连接就建立成功了,这样的话 对于初始化 OpenSergoClient 时的错误处理是不好设计的,即 Start 返回 error 后,是否需要上层进行重试。

我们需要针对这一块设计做完善。

@sczyh30 sczyh30 added the kind/enhancement Category issues or PRs related to enhancement label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

No branches or pull requests

1 participant