Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add mypy coverage outside fo opensearchpy/* #564

Closed
dblock opened this issue Nov 6, 2023 · 1 comment · Fixed by #566
Closed

[FEATURE] Add mypy coverage outside fo opensearchpy/* #564

dblock opened this issue Nov 6, 2023 · 1 comment · Fixed by #566
Assignees
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Nov 6, 2023

Is your feature request related to a problem?'

Coming from #563 where we merged type stubs. Add type coverage for tests, benchmarks, etc.

What solution would you like?

Edit noxfile, fix type errors.

+++ b/noxfile.py
@@ -82,7 +82,7 @@ def lint(session) -> None:
 
     # Run mypy on the package and then the type examples separately for
     # the two different mypy use-cases, ourselves and our users.
-    session.run("mypy", "--strict", "opensearchpy/")
+    session.run("mypy", "--strict", *SOURCE_FILES)
     session.run("mypy", "--strict", "test_opensearchpy/test_types/sync_types.py")
     session.run("mypy", "--strict", "test_opensearchpy/test_types/async_types.py")
@dblock dblock added enhancement New feature or request untriaged Need triage labels Nov 6, 2023
@saimedhi saimedhi removed the untriaged Need triage label Nov 6, 2023
@dblock
Copy link
Member Author

dblock commented Nov 6, 2023

Current state of https://github.com/dblock/opensearch-py/tree/rest-of-mypy

$ nox -rs format 

Found 237 errors in 61 files (checked 221 source files)
nox > Command mypy --strict setup.py noxfile.py opensearchpy/ test_opensearchpy/ utils/ samples/ benchmarks/ docs/ failed with exit code 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants