added highlight to search endpoint whitelist #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Pratt <[email protected]>
prattcmp
requested review from
VachaShah,
dblock,
harshavamsi and
shyim
as code owners
shyim
approved these changes
Dec 3, 2023
dblock
requested changes
Dec 4, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
============================================
- Coverage 24.19% 24.19% -0.01%
Complexity 1938 1938
============================================
Files 246 246
Lines 6865 6866 +1
============================================
Hits 1661 1661
- Misses 5204 5205 +1 ☔ View full report in Codecov by Sentry. |
|
@prattcmp Want to finish this? |
saimedhi
requested changes
Apr 30, 2024
| @@ -78,7 +78,8 @@ public function getParamWhitelist(): array | |||
| 'batched_reduce_size', | |||
| 'max_concurrent_shard_requests', | |||
| 'pre_filter_shard_size', | |||
| 'rest_total_hits_as_int' | |||
| 'rest_total_hits_as_int', | |||
| 'highlight' | |||
There was a problem hiding this comment.
Hi @prattcmp, it looks like highlight isn't a valid parameter for the Search API. I tested it. Search doesn't include the highlight parameter here.
If you think there's something missing, feel free to contribute! You can also consider contributing to the opensearch API specification here and adding any missing parameters. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fixes the whitelist for the search endpoint by adding "highlight". Maintainers should highly consider removing whitelist or making it optional.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.