Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov Tokenless upload #1155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Nov 20, 2024

We moved to a more complex workflow_run trigger due to issues codecov had with tokenless uploads for the past few months.

This was reported in codecov/codecov-action#1580 and recently resolved with version 5.0.7.

This change moves back to tokenless uploads which reduces risk and makes it easier to test any future updates and adds some support for codecov updates even with some test failures.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait force-pushed the CodeCovNoTokenTest branch 2 times, most recently from f003574 to 635d671 Compare November 20, 2024 21:47
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (d5b401c) to head (0c3acd7).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1155   +/-   ##
=========================================
  Coverage     80.76%   80.76%           
  Complexity     2948     2948           
=========================================
  Files           400      400           
  Lines         15104    15104           
  Branches       1021     1021           
=========================================
  Hits          12199    12199           
  Misses         2288     2288           
  Partials        617      617           
Flag Coverage Δ
unittests 80.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AndreKurait AndreKurait reopened this Nov 21, 2024
@AndreKurait AndreKurait force-pushed the CodeCovNoTokenTest branch 2 times, most recently from b9145a2 to 0c3acd7 Compare November 21, 2024 22:34
@AndreKurait AndreKurait changed the title Test tokenless upload Codecov Tokenless upload Nov 22, 2024
@AndreKurait AndreKurait marked this pull request as ready for review November 22, 2024 03:25
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants