Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Clean up code #86

Open
JohannesDaniel opened this issue Dec 7, 2024 · 1 comment
Open

[PROPOSAL] Clean up code #86

JohannesDaniel opened this issue Dec 7, 2024 · 1 comment

Comments

@JohannesDaniel
Copy link
Collaborator

As of now, there are many

  • Non-final class variables that could be final
  • Usages if unmodifiableList instead of List.of
  • Unused imports
  • Deprecated API usage
  • Commented out code
  • Code style issues

... and many many more (running code inspection reveals a massive amount of issues).

Furthermore, there are many inner classes, including inner classes within inner classes, which makes the code difficult to read.

The code should be cleaned up, probably not all at once, but rather stepwise.

@sstults
Copy link
Collaborator

sstults commented Dec 12, 2024

I agree with the step-wise approach. Maybe start with ones that have no chance of affecting the compiled code (commented out code, unused imports) and then take each next class of change in turn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants