Delete-job-details changes #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadinaBonuAlisherova
requested review from
joshpalis,
saratvemulapalli,
dbwiddis,
kaituo and
vibrantvarun
as code owners
|
@MadinaBonuAlisherova this is great work! It seems that some checks are failing : This error describes a format violation, in order to fix this just run The Developer Certificate of Origin check is also failing, in order to fix this, ensure that you sign off on your commit using |
Signed-off-by: Alisherova Madinabonu <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #372 +/- ##
============================================
- Coverage 28.77% 27.29% -1.49%
Complexity 97 97
============================================
Files 22 24 +2
Lines 1178 1242 +64
Branches 109 116 +7
============================================
Hits 339 339
- Misses 818 882 +64
Partials 21 21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a Delete Job Details Rest API with documentId as a input parameter. It will help to delete job details objects with issues with the help of API
Issues Resolved
Prerequisites
Additional context
create RestDeleteJobDetailsAction in path org.opensearch.jobscheduler.action
RestDeleteJobDetailsAction should extend abstract class BaseRestHandler
Override routes() and prepareRequest() method in RestDeleteJobDetailsAction class
Define two static strings in class
public static final String DELETE_JOB_DETAILS_ACTION = "delete_job_details_action";
public static final String DOCUMENT_ID = "document_id";
In routes method return a list of route with given Route below
new Route(DELETE, String.format(Locale.ROOT, "%s/%s/{%s}", JobSchedulerPlugin.JS_BASE_URI, "_delete_job_details", DOCUMENT_ID))
Override getName() method and return DELETE_JOB_DETAILS_ACTION
Create a public constructor in RestDeleteJobDetailsAction with JobDetailsService as argument and initialize the local variable
public RestDeleteJobDetailsAction(JobDetailsService jobDetailsService){
this.jobDetailsService=jobDetailsService;
}
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.