Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement][opensearch/opensearch-dashboards] ServiceMonitor is missing the ability to add a specific label to it #585

Open
eyenx opened this issue Aug 29, 2024 · 3 comments · Fixed by #586
Open

[Enhancement][opensearch/opensearch-dashboards] ServiceMonitor is missing the ability to add a specific label to it #585

eyenx opened this issue Aug 29, 2024 · 3 comments · Fixed by #586
Assignees
@eyenx
Labels
enhancement New feature or request

Comments

@eyenx
Copy link
Contributor

eyenx commented Aug 29, 2024

Is your feature request related to a problem? Please describe.
When enabling ServiceMonitor one might need to add a specific label to it to make it scrapable by Prometheus

Describe the solution you'd like
Additional serviceMonitor.selector value or extraLabels to add to the serviceMonitor

Describe alternatives you've considered
Just adding labels to the global labels value. But this would end up in the deployments and other resources as well.

Additional context
I will open up a PR myself.
@eyenx eyenx added enhancement New feature or request untriaged Issues that have not yet been triaged labels Aug 29, 2024
@eyenx eyenx mentioned this issue Aug 29, 2024
Merged
3 tasks
@prudhvigodithi
Copy link
Member

prudhvigodithi commented Aug 29, 2024 •
edited
Loading

[Triage]
Hey @eyenx thanks PR #586, we can take look and get this merged soon. We can 1st get this PR merged https://github.com/opensearch-project/helm-charts/pull/578/files and come back to #586.
Thank you
@peterzhuamazon @TheAlgo @VILJkid

@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Aug 29, 2024
@peterzhuamazon peterzhuamazon linked a pull request Aug 29, 2024 that will close this issue
[Backport 1.x] Add Service Monitor Resource #578
Merged
3 tasks
@peterzhuamazon peterzhuamazon removed a link to a pull request Sep 6, 2024
[Backport 1.x] Add Service Monitor Resource #578
Merged
3 tasks
@peterzhuamazon peterzhuamazon linked a pull request Sep 9, 2024 that will close this issue
feat(serviceMonitors): add option of additional Labels in serviceMonitor #586
Merged
3 tasks
@peterzhuamazon
Copy link
Member

This seems resolved by #586 now, please close the issue once backport is done on 1.x.

Thanks!

@eyenx
Copy link
Contributor Author

eyenx commented Sep 10, 2024

I will backport this to 1.x this week

@eyenx eyenx mentioned this issue Sep 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyenx eyenx

Labels
enhancement New feature or request
Projects
Engineering Effectiveness Board
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(serviceMonitors): add option of additional Labels in serviceMonitor eyenx/opensearch-charts
3 participants
@eyenx @prudhvigodithi @peterzhuamazon