Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][data-prepper] add annotations for data-prepper service #567

Open
vasili439 opened this issue Jul 26, 2024 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vasili439
Copy link

Is your feature request related to a problem? Please describe.
It's more related to security problem. I don't want to expose data-prepper service with AWS External LB but want to add annotation to create internal LB

Describe the solution you'd like
add

  {{- with .Values.service.annotations }}
  annotations:
    {{- toYaml . | nindent 4 }}
  {{- end }}

to templates/service.yaml

Describe alternatives you've considered
no

@vasili439 vasili439 added enhancement New feature or request untriaged Issues that have not yet been triaged labels Jul 26, 2024
@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Aug 15, 2024
@gaiksaya
Copy link
Member

[Triage]

Thanks for opening the issue. Please feel free to contribute until we get there.

@getsaurabh02 getsaurabh02 added the good first issue Good for newcomers label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

3 participants