Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample templates for text to visualziation #936

Merged

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Oct 28, 2024

Description

Add sample templates for text to visualization.
These templates will be used by OpenSearch-Dashboards plugin dashboards-assistant to setup text to visualization feature. Documentation could be found here: https://opensearch.org/docs/latest/dashboards/dashboards-assistant/text-to-visualization/

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Oct 28, 2024
@ruanyl ruanyl marked this pull request as ready for review November 11, 2024 03:42
@ruanyl
Copy link
Member Author

ruanyl commented Nov 11, 2024

@dbwiddis @owaiskazi19 Could you take a look the PR please?

@dbwiddis
Copy link
Member

dbwiddis commented Nov 11, 2024

@ruanyl Will do. I saw it earlier but it was in draft until just now.

Note the spotless check is failing (looks like trailing whitespace). Please run ./gradlew spotlessApply and commit the difference. Also add a section to the 2.x documentation on the change log.

@ruanyl ruanyl force-pushed the add-template-for-text-to-visualziation branch from 4649941 to ba05e6a Compare November 11, 2024 04:51
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending spotless fix

@owaiskazi19
Copy link
Member

@ruanyl can you also some description about the use case for this template in the PR?

Signed-off-by: Yulong Ruan <[email protected]>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.57%. Comparing base (9b9ebb2) to head (de6cae1).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #936      +/-   ##
============================================
- Coverage     78.07%   77.57%   -0.50%     
+ Complexity      996      993       -3     
============================================
  Files            99       99              
  Lines          4625     4714      +89     
  Branches        431      431              
============================================
+ Hits           3611     3657      +46     
- Misses          834      877      +43     
  Partials        180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yuye-aws
Copy link
Member

@ruanyl can you also some description about the use case for this template in the PR?

Description updated. Can u review again?

@yuye-aws
Copy link
Member

@ruanyl Is there going to be a PR adding t2vega_agent (without instruction)?

@dbwiddis dbwiddis merged commit e259c12 into opensearch-project:main Nov 19, 2024
19 of 20 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-936-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e259c12ebf40dcf8677343a1744643804f9efd02
# Push it to GitHub
git push --set-upstream origin backport/backport-936-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-936-to-2.x.

@opensearch-trigger-bot opensearch-trigger-bot bot added the backport-failed Applied to PRs when the automatic backport fails label Nov 19, 2024
@dbwiddis
Copy link
Member

Probably a changelog conflict with #968. Will wait until that's merged and toggle the backport label

@dbwiddis dbwiddis added backport 2.x backport PRs to 2.x branch and removed backport 2.x backport PRs to 2.x branch labels Nov 19, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-936-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e259c12ebf40dcf8677343a1744643804f9efd02
# Push it to GitHub
git push --set-upstream origin backport/backport-936-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-936-to-2.x.

dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Nov 19, 2024
* add sample templates for text to visualziation

Signed-off-by: Yulong Ruan <[email protected]>

* update text to visualziation prompt

Signed-off-by: Yulong Ruan <[email protected]>

* Update CHANGELOG

Signed-off-by: Yulong Ruan <[email protected]>

* trailing whitespace

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
@dbwiddis dbwiddis removed the backport-failed Applied to PRs when the automatic backport fails label Nov 19, 2024
dbwiddis pushed a commit to dbwiddis/flow-framework that referenced this pull request Nov 20, 2024
* add sample templates for text to visualziation

Signed-off-by: Yulong Ruan <[email protected]>

* update text to visualziation prompt

Signed-off-by: Yulong Ruan <[email protected]>

* Update CHANGELOG

Signed-off-by: Yulong Ruan <[email protected]>

* trailing whitespace

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
owaiskazi19 pushed a commit that referenced this pull request Nov 25, 2024
…969)

add sample templates for text to visualziation (#936)

* add sample templates for text to visualziation



* update text to visualziation prompt



* Update CHANGELOG



* trailing whitespace



---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Yulong Ruan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants