GET API to fetch workflow-step.json #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
============================================
- Coverage 72.88% 72.17% -0.71%
- Complexity 601 613 +12
============================================
Files 75 79 +4
Lines 2998 3069 +71
Branches 233 237 +4
============================================
+ Hits 2185 2215 +30
- Misses 710 752 +42
+ Partials 103 102 -1 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Jan 10, 2024
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowStepAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowStepAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStepTransportAction.java
Show resolved
Hide resolved
dbwiddis
reviewed
Jan 10, 2024
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStepTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowStepAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowStepAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStepTransportAction.java
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
dbwiddis
approved these changes
Jan 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Implemented GET API for workflow step Signed-off-by: Owais Kazi <[email protected]> * Added rest test case Signed-off-by: Owais Kazi <[email protected]> * Added tests and javadocs Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> * Removed CreateIndex and CreateIngestPipeline from json Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit ebf8b90) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Jan 10, 2024
GET API to fetch workflow-step.json (#394) * Implemented GET API for workflow step * Added rest test case * Added tests and javadocs * Addressed PR comments * Removed CreateIndex and CreateIngestPipeline from json --------- (cherry picked from commit ebf8b90) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
reta
pushed a commit
to opensearch-project/security
that referenced
this pull request
Jan 11, 2024
Description Adds permission for a new Get Workflow Step API. opensearch-project/flow-framework#394 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: owaiskazi19 <[email protected]>
opensearch-trigger-bot bot
pushed a commit
to opensearch-project/security
that referenced
this pull request
Jan 11, 2024
Description Adds permission for a new Get Workflow Step API. opensearch-project/flow-framework#394 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: owaiskazi19 <[email protected]> (cherry picked from commit b8a315a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
Description Adds permission for a new Get Workflow Step API. opensearch-project/flow-framework#394 ### Check List - [ ] New functionality includes testing - [ ] New functionality has been documented - [ ] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: owaiskazi19 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves the below:
create_indexandcreate_ingest_pipelinefrom the jsonRequest:
Refer this for response.
Issues Resolved
Fixes #364
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.