Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Migrations directory #8616

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Add Migrations directory #8616

merged 7 commits into from
Oct 29, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Description

The following PR adds the initial content from the migrations wiki. The content itself has not been reviewed by a writer. @sumobrian and myself plan to address each piece of content in smaller chunks.

The documentation found within this PR will not be published until PR #8615 is merged. #8615 will not be merged until the content has been reviewed.

Issues Resolved

Closes #[insert issue number]

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Contributor

@sumobrian sumobrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though an update was done 4 days ago, it looks like there are changes that are older than 4 days that have not been applied. Looking at git logs changes after in the following commit and after have not been added:
commit 6c64d5b9e249de3578e9676bb80f30e41087dc4d
Author: Brian Presley [email protected]
Date: Thu Oct 17 17:15:18 2024 -0500

Regardless, I think we will have to do a sync and define a cut-over point so I'm okay approving as-is.

There's a reference to the old architecture that should be removed.


Deploying to AWS (covered later in the guide) will deploy the following into your AWS account:

<img width="926" alt="image" src="https://github.com/user-attachments/assets/49f748fc-f513-462a-ad01-f8735c87abe2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated

@Naarcha-AWS
Copy link
Collaborator Author

Even though an update was done 4 days ago, it looks like there are changes that are older than 4 days that have not been applied. Looking at git logs changes after in the following commit and after have not been added: commit 6c64d5b9e249de3578e9676bb80f30e41087dc4d Author: Brian Presley [email protected] Date: Thu Oct 17 17:15:18 2024 -0500

Regardless, I think we will have to do a sync and define a cut-over point so I'm okay approving as-is.

There's a reference to the old architecture that should be removed.

I'll go ahead and update this before we merge.

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naarcha-AWS Naarcha-AWS merged commit 8abb45a into main Oct 29, 2024
7 checks passed
@Naarcha-AWS Naarcha-AWS deleted the migration-assistant-directory branch October 29, 2024 15:46
epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
* Add migrations directory.

Signed-off-by: Archer <[email protected]>

* Add index pages for sub-sections

Signed-off-by: Archer <[email protected]>

* Switch file names to lower case

Signed-off-by: Archer <[email protected]>

* Add latest wiki edits

Signed-off-by: Archer <[email protected]>

* Add migration architecture overview.

Signed-off-by: Archer <[email protected]>

* Review feedback.

Signed-off-by: Archer <[email protected]>

---------

Signed-off-by: Archer <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants