Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: add pnpm support #302

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

williamfzc
Copy link

@ba11b0y
Copy link
Contributor

ba11b0y commented Aug 22, 2023

Hey @williamfzc
Thanks for the PR!
We're trying to revamp this project to use the parsers project.

@williamfzc
Copy link
Author

williamfzc commented Aug 22, 2023

Hey @williamfzc Thanks for the PR! We're trying to revamp this project to use the parsers project.

Looks great, but what should I do next?
I notice that pkg/modules still keeps lots of duplicated code which same as the parser.

Maybe I should create another PR in parsers first? :)

@ba11b0y
Copy link
Contributor

ba11b0y commented Aug 22, 2023

Yes. Once the parser is good enough you can register it here

And then you can try your parser with the new command introduced here because it already imports the parsers.

@williamfzc williamfzc changed the title feat: add pnpm support WIP: feat: add pnpm support Aug 23, 2023
@williamfzc
Copy link
Author

williamfzc commented Aug 27, 2023

Hi @ba11b0y ,

PR for parsers (opensbom-generator/parsers#75) is finished. Tested with tool-python.

After it has been merged, I can start editing this PR for generator. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants