"MigrateHamcrestToAssertJ" recipe does not fully migrate comparesEqualTo matcher

[jtama]

What version of OpenRewrite are you using?

I am using

• OpenRewrite v2.22.0
• Maven/Gradle plugin ?
• rewrite-testing-frameworks v2.22.0

How are you running OpenRewrite?

I am using executing openrewrite through the shell, and my project is a single module project.

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.testing.junit5.JUnit4to5Migration,org.openrewrite.java.testing.assertj.Assertj -Drewrite.exportDatatables=true

What is the smallest, simplest way to reproduce the problem?

import java.math.BigDecimal;
import static org.hamcrest.Matchers.comparesEqualTo;

public class DummyTest {

    @Test
    public void dummyTest() {
        assertThat(new BigDecimal("2"), comparesEqualTo(new BigDecimal("2.0")));
    }
}

What did you expect to see?

import java.math.BigDecimal;
import static org.assertj.core.api.Assertions.assertThat;

public class DummyTest {

    @Test
    public void dummyTest() {
        assertThat(new BigDecimal("2")).isEqualTo(new BigDecimal("2.0"));
    }
}

What did you see instead?

import java.math.BigDecimal;
import static org.hamcrest.Matchers.comparesEqualTo;

public class DummyTest {

    @Test
    public void dummyTest() {
        assertThat(new BigDecimal("2"), comparesEqualTo(new BigDecimal("2.0")));
    }
}

I think it's all linked to to this line https://github.com/openrewrite/rewrite-testing-frameworks/blob/main/src/main/resources/META-INF/rewrite/hamcrest.yml#L65 that limits the type argument to String.

I can provide a PR if you like.

[timtebeek]

Hi @jtama ; thanks for calling that out! We had indeed added that quick limit to String type following

• HamcrestMatcherToAssertJ wrongfully translates comparesEqualTo to isEqualTo instead of isEqualByComparingTo #468
• Limit Hamcrest replacements by type #469

I hadn't since taken the time to reevaluate which other types are fine to support there as well; I'd welcome a PR that adds a few more allowed types to be converted, thanks!

[jtama]

Ok I'll do that.