JUnit 4 to 5 migration does not add the mockito-junit-jupiter dependency

[FieteO]

What version of OpenRewrite are you using?

I am using

• OpenRewrite v5.22.0

How are you running OpenRewrite?

I am using the command line invocation:

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-spring:RELEASE -Drewrite.activeRecipes=org.openrewrite.java.spring.boot2.SpringBoot2JUnit4to5Migration -Drewrite.exportDatatables=true

What is the smallest, simplest way to reproduce the problem?

import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;

@RunWith(MockitoJUnitRunner.class)
public class MyClass {}

...
<dependencies>
  <dependency>
    <groupId>org.junit.jupiter</groupId>
    <artifactId>junit-jupiter</artifactId>
    <scope>test</scope>
  </dependency>
  <dependency>
    <groupId>org.mockito</groupId>
    <artifactId>mockito-core</artifactId>
    <scope>test</scope>
  </dependency>
</dependencies>

What did you expect to see?

...
<dependencies>
  <dependency>
    <groupId>org.junit.jupiter</groupId>
    <artifactId>junit-jupiter</artifactId>
    <scope>test</scope>
  </dependency>
  <dependency>
    <groupId>org.mockito</groupId>
    <artifactId>mockito-core</artifactId>
    <scope>test</scope>
  </dependency>
  <dependency>
      <groupId>org.mockito</groupId>
      <artifactId>mockito-junit-jupiter</artifactId>
      <scope>test</scope>
  </dependency>
</dependencies>

What did you see instead?

The mockito-junit-jupiter dependency is not added.

...
<dependencies>
  <dependency>
    <groupId>org.junit.jupiter</groupId>
    <artifactId>junit-jupiter</artifactId>
    <scope>test</scope>
  </dependency>
  <dependency>
    <groupId>org.mockito</groupId>
    <artifactId>mockito-core</artifactId>
    <scope>test</scope>
  </dependency>
</dependencies>

Are you interested in contributing a fix to OpenRewrite?

No

[timtebeek]

Thanks for the report! As a bit of context we do have a recipe step to add that dependency:

rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/mockito.yml

Lines 158 to 163 in 9118a3c

	- org.openrewrite.java.dependencies.AddDependency:
	groupId: org.mockito
	artifactId: mockito-junit-jupiter
	version: 3.x
	onlyIfUsing: org.mockito.junit.jupiter.*
	acceptTransitive: true

Which is part of our org.openrewrite.java.testing.mockito.Mockito1to3Migration & org.openrewrite.java.testing.mockito.Mockito1to4Migration.

You've specifically ran org.openrewrite.java.spring.boot2.SpringBoot2JUnit4to5Migration, which does include org.openrewrite.java.testing.junit5.JUnit4to5Migration.
https://github.com/openrewrite/rewrite-spring/blob/729164fd713cbd0bfce44e582b0d613f4d1965b0/src/main/resources/META-INF/rewrite/spring-boot-24.yml#L100-L113

That JUnit4to5Migration also includes UseMockitoExtension, which includes the Mockito1to4Migration:

rewrite-testing-frameworks/src/main/resources/META-INF/rewrite/junit5.yml

Lines 49 to 76 in 6d665a0

	name: org.openrewrite.java.testing.junit5.JUnit4to5Migration
	displayName: JUnit Jupiter migration from JUnit 4.x
	description: Migrates JUnit 4.x tests to JUnit Jupiter.
	tags:
	- testing
	- junit
	preconditions:
	- org.openrewrite.java.search.DoesNotUseType:
	fullyQualifiedTypeName: org.testng..*
	includeImplicit: true
	recipeList:
	- org.openrewrite.java.testing.junit5.UseWiremockExtension
	- org.openrewrite.java.testing.junit5.IgnoreToDisabled
	- org.openrewrite.java.testing.junit5.ThrowingRunnableToExecutable
	- org.openrewrite.java.testing.junit5.RemoveObsoleteRunners:
	obsoleteRunners:
	- org.junit.runners.JUnit4
	- org.junit.runners.BlockJUnit4ClassRunner
	- org.openrewrite.maven.RemovePluginDependency:
	pluginGroupId: org.apache.maven.plugins
	pluginArtifactId: maven-surefire-plugin
	groupId: org.apache.maven.surefire
	artifactId: surefire-junit*
	- org.openrewrite.java.testing.junit5.UpgradeSurefirePlugin
	- org.openrewrite.java.testing.junit5.AddHamcrestJUnitDependency
	- org.openrewrite.java.testing.junit5.UseHamcrestAssertThat
	- org.openrewrite.java.testing.junit5.MigrateAssumptions
	- org.openrewrite.java.testing.junit5.UseMockitoExtension

[timtebeek]

I've moved the issue as it seems more closely related to rewrite-testing-frameworks. I wonder if running UseMockitoExtension later in JUnit4to5Migration would help the conditional onlyIfUsing: org.mockito.junit.jupiter.* in the AddDependency to detect that we should add the dependency. Probably best tried with a unit test that has a class with JUnit 4 and the Mockito runner, as well as a pom.xml, and then run JUnit4to5Migration and assert the dependency is added.