AssertionsArgumentOrder does not work with Junit 4 assertions

[adambir]

AssertionsArgumentOrder does not work with Junit 4 assertions, even though the main documentation mentions it :

Assertions such as org.junit.Assert.assertEquals expect the first argument to be the expected value and the second argument to be the actual value [...]

What version of OpenRewrite are you using?

I am using

• Maven/Gradle plugin v5.43.2
• rewrite-testing-frameworks v2.21.0

How are you running OpenRewrite?

Using the mvn plugin with a multi project module

What is the smallest, simplest way to reproduce the problem?

              import static org.junit.Assert.assertEquals;
                          
              class MyTest {
                  void someMethod() {
                      assertEquals(result(), "result");
                      assertEquals(result(), "result", "message");
                      assertEquals(0L, 1L);
                  }
                  String result() {
                      return "result";
                  }
              }

What did you expect to see?

              import static org.junit.Assert.assertEquals;
                          
              class MyTest {
                  void someMethod() {
                      assertEquals("result", result());
                      assertEquals("result", result(), "message");
                      assertEquals(0L, 1L);
                  }
                  String result() {
                      return "result";
                  }
              }

What did you see instead?

```java
              import static org.junit.Assert.assertEquals;
                          
              class MyTest {
                  void someMethod() {
                      assertEquals(result(), "result");
                      assertEquals(result(), "result", "message");
                      assertEquals(0L, 1L);
                  }
                  String result() {
                      return "result";
                  }
              }

Are you interested in contributing a fix to OpenRewrite?

Yes, I'd like to propose a PR to generalize the behaviour to Junit 4. I would first need confirmation that this is something that could be considered.

[adambir]

Added a PR #637