diff --git a/src/main/java/org/openrewrite/staticanalysis/URLEqualsHashCode.java b/src/main/java/org/openrewrite/staticanalysis/URLEqualsHashCode.java new file mode 100644 index 000000000..d6970890a --- /dev/null +++ b/src/main/java/org/openrewrite/staticanalysis/URLEqualsHashCode.java @@ -0,0 +1,69 @@ +/* + * Copyright 2024 the original author or authors. + *

+ * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + *

+ * https://www.apache.org/licenses/LICENSE-2.0 + *

+ * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.openrewrite.staticanalysis; + +import com.google.errorprone.refaster.annotation.AfterTemplate; +import com.google.errorprone.refaster.annotation.BeforeTemplate; +import org.openrewrite.java.template.RecipeDescriptor; + +import java.net.URI; +import java.net.URL; + +@SuppressWarnings("UrlHashCode") +@RecipeDescriptor( + name = "URL Equals and Hash Code", + description = "Uses of equals() and hashCode() cause java.net.URL to make blocking internet connections. " + + "Instead, use java.net.URI.", + tags = {"errorprone"} +) +public class URLEqualsHashCode { + + @RecipeDescriptor( + name = "URL Equals", + description = "Uses of equals() cause java.net.URL to make blocking internet connections. " + + "Instead, use java.net.URI.", + tags = {"errorprone"} + ) + public static class URLEquals { + @BeforeTemplate + boolean before(URL a, URL b) { + return a.equals(b); + } + + @AfterTemplate + boolean after(URL a, URL b) { + return URI.create(a.toString()).equals(URI.create(b.toString())); + } + } + + @RecipeDescriptor( + name = "URL Hash Code", + description = "Uses of hashCode() cause java.net.URL to make blocking internet connections. " + + "Instead, use java.net.URI.", + tags = {"errorprone"} + ) + public static class URLHashCode { + @BeforeTemplate + int before(URL a) { + return a.hashCode(); + } + + @AfterTemplate + int after(URL a) { + return URI.create(a.toString()).hashCode(); + } + } +} diff --git a/src/test/java/org/openrewrite/staticanalysis/URLEqualsHashCodeTest.java b/src/test/java/org/openrewrite/staticanalysis/URLEqualsHashCodeTest.java new file mode 100644 index 000000000..577f2d89b --- /dev/null +++ b/src/test/java/org/openrewrite/staticanalysis/URLEqualsHashCodeTest.java @@ -0,0 +1,88 @@ +/* + * Copyright 2024 the original author or authors. + *

+ * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + *

+ * https://www.apache.org/licenses/LICENSE-2.0 + *

+ * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.openrewrite.staticanalysis; + +import org.junit.jupiter.api.Test; +import org.openrewrite.test.RecipeSpec; +import org.openrewrite.test.RewriteTest; + +import static org.openrewrite.java.Assertions.java; + +public class URLEqualsHashCodeTest implements RewriteTest { + + @Override + public void defaults(RecipeSpec spec) { + spec.recipe(new URLEqualsHashCodeRecipes()); + } + + @Test + void urlHashCode() { + rewriteRun( + java(""" + import java.net.URL; + + class Test { + public void test() { + URL url = new URL("https://example.com"); + int hash = url.hashCode(); + } + } + """, + """ + import java.net.URI; + import java.net.URL; + + class Test { + public void test() { + URL url = new URL("https://example.com"); + int hash = URI.create(url.toString()).hashCode(); + } + } + """ + ) + ); + } + + @Test + void urlEquals() { + rewriteRun( + java(""" + import java.net.URL; + + class Test { + public void test() { + URL url1 = new URL("https://example.com"); + URL url2 = new URL("https://example.com"); + boolean equals = url1.equals(url2); + } + } + """, + """ + import java.net.URI; + import java.net.URL; + + class Test { + public void test() { + URL url1 = new URL("https://example.com"); + URL url2 = new URL("https://example.com"); + boolean equals = URI.create(url1.toString()).equals(URI.create(url2.toString())); + } + } + """ + ) + ); + } +}