Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all common static analysis issues as part of OpenRewrite best practices #16

Open
timtebeek opened this issue Mar 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@timtebeek
Copy link
Contributor

timtebeek commented Mar 12, 2024

What problem are you trying to solve?

Prevent common issues in recipes and rewrite tests/

Describe the solution you'd like

Run org.openrewrite.staticanalysis.CommonStaticAnalysis as part of

type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.recipes.OpenRewriteBestPractices
displayName: OpenRewrite best practices
description: Best practices for OpenRewrite recipe development.
recipeList:
- org.openrewrite.recipes.JavaRecipeBestPractices
- org.openrewrite.recipes.RecipeTestingBestPractices

But only on Recipe and RewriteTest classes, as per the preconditions there.

Have you considered any alternatives or workarounds?

We could run a selection, but that's harder to maintain.

Additional context

Already did a quick attempt, but that needed some small fixes.
openrewrite/rewrite-spring@0bb7731

@timtebeek timtebeek added the enhancement New feature or request label Mar 12, 2024
@timtebeek timtebeek moved this to Backlog in OpenRewrite Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant