Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HttpRequest type parameter and remove RouteMatch method parameter for implementations of io.micronaut.security.rules.SecurityRule #85

Open
jeremyg484 opened this issue Jul 19, 2023 · 0 comments
Open

Add HttpRequest type parameter and remove RouteMatch method parameter for implementations of io.micronaut.security.rules.SecurityRule #85

jeremyg484 opened this issue Jul 19, 2023 · 0 comments
Assignees
@jeremyg484
Labels
recipe Recipe requested
Milestone
Micronaut 4.0

Comments

@jeremyg484
Copy link
Collaborator

Existing Micronaut Framework 3 custom implementations of io.micronaut.security.rules.SecurityRule will need to have HttpRequest added as a type parameter of the interface in their implements clause, and their check method will need to have the RouteMatch parameter removed.

See https://github.com/micronaut-projects/micronaut-security/pull/1320/files#diff-b8c51df0759135f42f75cd53042646e31557017695d475736e08af4e3aabc573 for the interface changes.

This is a continuation of the changes noted in issue #63
@jeremyg484 jeremyg484 added the recipe Recipe requested label Jul 19, 2023
@jeremyg484 jeremyg484 added this to the Micronaut 4.0 milestone Jul 19, 2023
@jeremyg484 jeremyg484 self-assigned this Jul 19, 2023
@jeremyg484 jeremyg484 changed the title Add HttpRequest type parameter and remove RouteMatch method parameter from implementations of io.micronaut.security.rules.SecurityRule Add HttpRequest type parameter and remove RouteMatch method parameter for implementations of io.micronaut.security.rules.SecurityRule Jul 19, 2023
@timtebeek timtebeek moved this to Recipes Wanted in OpenRewrite Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyg484 jeremyg484

Labels
recipe Recipe requested
Projects
OpenRewrite
Status: Recipes Wanted
Milestone
Micronaut 4.0
Development

No branches or pull requests
1 participant
@jeremyg484