Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaunchDarkly Java SDK 6.x & 7.x Migration #12

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Conversation

shanman190
Copy link
Collaborator

@shanman190 shanman190 commented Nov 15, 2023

What's changed?

Perform necessary migrations for the LaunchDarkly Java SDK 5.x to 6.x

What's your motivation?

Fixes gh-3

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've added the license header to any new files through ./gradlew licenseFormat
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good! Thanks for taking this on.

@timtebeek timtebeek marked this pull request as ready for review November 16, 2023 20:40
@shanman190 shanman190 linked an issue Nov 17, 2023 that may be closed by this pull request
@timtebeek timtebeek changed the title LaunchDarkly Java SDK 6.x Migration LaunchDarkly Java SDK 6.x & 7.x Migration Nov 17, 2023
@timtebeek timtebeek merged commit 7ec7748 into main Nov 17, 2023
1 check passed
@timtebeek timtebeek deleted the feature/migrate-6.x branch November 17, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Java SDK 6.x to 7.x migration Java SDK 5.x to 6.x Migration
2 participants