-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LaunchDarkly Java SDK 6.x & 7.x Migration #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanman190
commented
Nov 15, 2023
src/test/java/org/openrewrite/launchdarkly/UpgradeLaunchDarkly6Test.java
Outdated
Show resolved
Hide resolved
shanman190
force-pushed
the
feature/migrate-6.x
branch
from
November 15, 2023 15:37
3ffbe14
to
ed77ed6
Compare
shanman190
force-pushed
the
feature/migrate-6.x
branch
from
November 15, 2023 15:51
ed77ed6
to
043913d
Compare
timtebeek
reviewed
Nov 15, 2023
src/test/java/org/openrewrite/launchdarkly/UpgradeLaunchDarkly6Test.java
Outdated
Show resolved
Hide resolved
timtebeek
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good! Thanks for taking this on.
timtebeek
changed the title
LaunchDarkly Java SDK 6.x Migration
LaunchDarkly Java SDK 6.x & 7.x Migration
Nov 17, 2023
Unlikely folks would run these separately, as it's only one dependency; if they would want to they can run `UpgradeDependencyVersion` separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Perform necessary migrations for the LaunchDarkly Java SDK 5.x to 6.x
What's your motivation?
Fixes gh-3
Anyone you would like to review specifically?
@timtebeek
Checklist
./gradlew licenseFormat