Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using renv suggests packages are not installed #163

Open
nikolas-burkoff opened this issue Jul 6, 2022 · 3 comments
Open

When using renv suggests packages are not installed #163

nikolas-burkoff opened this issue Jul 6, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@nikolas-burkoff
Copy link
Contributor

nikolas-burkoff commented Jul 6, 2022

renv::install only installs Depends, Imports and LinkingTo not Suggests

renv::install(repo_dir_external)

This is a gap compared to using staged.deps without renv where remotes::install_deps allows you to do it

We should move packages around so things are installed to make renv/not renv behaviour consistent

temp_package_name <- paste0(desc_obj$get("Package"), ".dependencies")

@nikolas-burkoff
Copy link
Contributor Author

See rstudio/renv#933 (comment)

@nikolas-burkoff
Copy link
Contributor Author

See rstudio/renv#1087

@nikolas-burkoff
Copy link
Contributor Author

The renv issue above has been fixed so once it has been released we can

  1. Set the renv version in our description file >= 0.17.0
  2. This https://github.com/openpharma/staged.dependencies/blob/main/R/git_tools.R#L201 needs a "..." argument added and should automatically pick up the new dependencies argument in renv::install
  3. Docs e.g. here and here should be updated
  4. Update ticket here - so the vignette can show how to handle external package installation when using renv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant