Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check power for edge cases marginal power 0 or 1 #47

Open
EeethB opened this issue Jul 17, 2023 · 1 comment
Open

Check power for edge cases marginal power 0 or 1 #47

EeethB opened this issue Jul 17, 2023 · 1 comment

Comments

@EeethB
Copy link
Contributor

EeethB commented Jul 17, 2023

Results are currently different for calculate_power(g, marginal_power = c(0, 0, 0), sim_seed = 51123, force_closure = TRUE) and calculate_power(g, marginal_power = c(0, 0, 0), sim_seed = 51123).

Should validation exclude 0/1 for marginal power?

@EeethB
Copy link
Contributor Author

EeethB commented Dec 4, 2023

Running graph_calculate_power() regardless of test type performs correctly now regardless of test type when power_marginal is all 0 or all 1. The only issue I've found still is when power_marginal is has a 0 or 1, and alpha is also the corresponding value (0 or 1). Perhaps validation should exclude 0/1 for alpha, since that's a null check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant