Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DesignOrdinal #856

Open
Puzzled-Face opened this issue Sep 11, 2024 · 0 comments
Open

Refactor DesignOrdinal #856

Puzzled-Face opened this issue Sep 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Puzzled-Face
Copy link
Collaborator

Puzzled-Face commented Sep 11, 2024

Currently, DesignOrdinal and RuleDesignOrdinal require slot values that are subclasses of the ordinal variant of the corresponding binary rule. For example, the cohort_size slot must contain an object of class CohortSizeOrdinal. This forbids the use of rules based on different toxicity grades. For example,

The size of the next cohort will be the larger of the sizes defined by the following rules

  • If no grade 1 toxicities have been reported then the cohort size is 1, otherwise it is 3.
  • If no grade 2 toxicities have been reported, then the cohort size is one, otherwise it is 5.

This change can be supported by first implementing issue #855 and then overriding the slot classes in RuleDesignOrdinal and modifying the validation of RuleDesignOrdinal objects to ensure that slots relating to Rules ensure that the slot contains either

  • an object of an ordinal-based Rule or
  • an object which is a list-based Rule, each of whose elements is an object of an ordinal-based Rule.
@Puzzled-Face Puzzled-Face added the enhancement New feature or request label Sep 11, 2024
@Puzzled-Face Puzzled-Face changed the title Refactor Designordinal Refactor DesignOrdinal Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant