Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: MRI-NUFFT: Doing non-Cartesian MRI has never been easier #7501

Open
editorialbot opened this issue Nov 19, 2024 · 13 comments
Open
Labels
pre-review Python Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @paquiteau (Pierre-Antoine Comby)
Repository: https://github.com/mind-inria/mri-nufft
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0849eb1abe87b8cd2edc5dbd95e8318c"><img src="https://joss.theoj.org/papers/0849eb1abe87b8cd2edc5dbd95e8318c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0849eb1abe87b8cd2edc5dbd95e8318c/status.svg)](https://joss.theoj.org/papers/0849eb1abe87b8cd2edc5dbd95e8318c)

Author instructions

Thanks for submitting your paper to JOSS @paquiteau. Currently, there isn't a JOSS editor assigned to your paper.

@paquiteau if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Nov 19, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.16 s (737.3 files/s, 212470.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              1              1              1          12196
Python                          91           3081           6801          10522
YAML                             6             82             34            479
reStructuredText                18            313            302            378
TeX                              1              9              0            145
Markdown                         1             33              0            104
TOML                             1             18              3             58
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           120           3541           7148          23891
-------------------------------------------------------------------------------

Commit count by author:

   279	Pierre-antoine Comby
    57	Pierre-Antoine Comby
    37	Guillaume DAVAL-FREROT
    27	Chaithya G R
    10	chaithyagr
     7	Philippe Ciuciu
     6	Guillaume Daval-Frérot
     6	LenaOudjman
     3	Caini Pan
     3	Daval-G
     3	Matteo Cencini
     2	Maxime Bertrait
     1	Asma TANABENE

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1255

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1109/TMI.2002.808360 is OK
- 10.1109/tsp.2002.807005 is OK
- 10.1109/TCI.2023.3240081 is OK
- 10.1016/j.ascom.2020.100402 is OK
- 10.5281/zenodo.7982256 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Berkley Advanced Reconstruction Toolbox
- No DOI given, and none found for title: SigPy: A Python Package for High Performance Itera...
- No DOI given, and none found for title: gpuNUFFT - An Open Source GPU Library for 3D Regri...
- No DOI given, and none found for title: TorchKbNufft: A High-Level, Hardware-Agnostic Non-...
- No DOI given, and none found for title: SNAKE-fMRI: A Modular fMRI Simulator from the Spac...
- No DOI given, and none found for title: PySAP-MRI: A Python Package for MR Image Reconstru...

❌ MISSING DOIs

- 10.1109/ipdpsw52791.2021.00105 may be a valid DOI for title: cuFINUFFT: A Load-Balanced GPU Library for General...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

DIRECT: Deep Image REConstruction Toolkit
Submitting author: @georgeyiasemis
Handling editor: @osorensen (Active)
Reviewers: @estenhl, @sairamgeethanath
Similarity score: 0.7431

GIRFReco.jl: An Open-Source Pipeline for Spiral Magnetic Resonance Image (MRI) Reconstruction in Julia
Submitting author: @alexjaffray
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @cncastillo, @mathieuboudreau, @felixhorger
Similarity score: 0.7327

Radial Interstices Enable Speedy Low-volume Imaging
Submitting author: @spinicist
Handling editor: @emdupre (Active)
Reviewers: @uecker, @MartinK84
Similarity score: 0.7277

Off-resonance CorrecTion OPen soUrce Software (OCTOPUS)
Submitting author: @imr-framework
Handling editor: @jni (Retired)
Reviewers: @puolival, @emilljungberg
Similarity score: 0.7177

QMRTools: a Mathematica toolbox for quantitative MRI analysis.
Submitting author: @mfroeling
Handling editor: @cMadan (Retired)
Reviewers: @grlee77, @JoshKarpel, @rljacobson
Similarity score: 0.7171

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Nov 19, 2024

@paquiteau Dear author, thanks for this submission. I am the AEiC on this track and here to help process the initial steps. Before we proceed, please can you have a look at the following points:

  • Please study the above reference check ☝️ and see if you can address any of the reported potential DOI issues. You can add/amend DOI entries in your .bib file, and call @editorialbot check references here to check them again.
  • Your project appears to lack contributing guidelines at the moment. Please work to add these and to mention/link to them in your README. You could for instance create a CONTRIBUTING.md file (see here for some examples: https://contributing.md/example/).

@Kevin-Mattheus-Moerman
Copy link
Member

@paquiteau Just to let you know, we are currently managing a large backlog of submissions and the editors most appropriate for your area are all already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 19, 2024
@paquiteau
Copy link

Hi @Kevin-Mattheus-Moerman thanks for starting the review process.

I have added the CONTRIBUTING.md and updated the bib references whenever possible (sadly ISMRM abstracts do not have DOIs, that is one of the reasons we are doing this JOSS submission actually)

For reviewers, I could suggest JeffFessler or guanhuaw (however, I am currently a reviewer for their JOSS submission for MIRTorch: #7340)

Then there is possibly uecker, mathieuboudreau, jonbmartin (also a reviewer of MIRTorch)

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.48550/arXiv.2102.08463 is OK
- 10.5281/zenodo.592960 is OK
- 10.1109/TMI.2002.808360 is OK
- 10.1109/tsp.2002.807005 is OK
- 10.1109/TCI.2023.3240081 is OK
- 10.48550/arXiv.2404.08282 is OK
- 10.1016/j.ascom.2020.100402 is OK
- 10.5281/zenodo.7982256 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: SigPy: A Python Package for High Performance Itera...
- No DOI given, and none found for title: gpuNUFFT - An Open Source GPU Library for 3D Regri...
- No DOI given, and none found for title: TorchKbNufft: A High-Level, Hardware-Agnostic Non-...
- No DOI given, and none found for title: PySAP-MRI: A Python Package for MR Image Reconstru...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

@paquiteau thanks for making those changes, looks good so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

3 participants