Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] VERILATOR_INSTALL_DIR is not set proprely in setup-env.sh #2534

Open
1 task done
Mabdalshakour opened this issue Oct 7, 2024 · 1 comment
Open
1 task done
Assignees
Labels
Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system

Comments

@Mabdalshakour
Copy link

Is there an existing CVA6 bug for this?

  • I have searched the existing bug issues

Bug Description

In setup-env.sh line 45, VERILATOR_INSTALL_DIR is set to "$ROOT_PROJECT"/tools/verilator which doesn't take the VERILATOR_HASH into account like what install-verilator.sh does in line 40, where it sets it to $ROOT_PROJECT/tools/verilator-$VERILATOR_HASH. That makes verilator unreachable except for running smoke-tests.sh. You can't source setup-env.sh as a standalone.

@Mabdalshakour Mabdalshakour added the Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system label Oct 7, 2024
@Mabdalshakour Mabdalshakour changed the title [BUG] <title>VERILATOR_INSTALL_DIR is not set proprely in setup-env.sh [BUG] VERILATOR_INSTALL_DIR is not set proprely in setup-env.sh Oct 7, 2024
@valentinThomazic
Copy link
Contributor

valentinThomazic commented Oct 28, 2024

Maybe I am failing to see the issue but I don't see it on the current latest commit (ab2283c) since the verif/regress/install-verilator.sh script will install the binary in tools/verilator/bin which is the default path in the verif/sim/setup-env.sh script.
Please confirm you are still encountering the issue on ab2283c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug For bugs in the RTL, Documentation, Verification environment or Tool and Build system
Projects
None yet
Development

No branches or pull requests

2 participants