Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[digiplex] Received thread stops when an exception happens inside #17828

Open
rmichalak opened this issue Dec 1, 2024 · 1 comment · May be fixed by #17829 or #17864
Open

[digiplex] Received thread stops when an exception happens inside #17828

rmichalak opened this issue Dec 1, 2024 · 1 comment · May be fixed by #17829 or #17864
Labels
bug An unexpected problem or unintended behavior of an add-on

Comments

@rmichalak
Copy link

Receiver thread is only protected against IOException (here) but sometimes (due to random communication issues), a different kind of exception can occur in which case the thing is not properly reinitialized (via handleCommunicationError) and the thread stops which means the communication with the alarm system is lost.

Same thing can potentially happen in the sender thread (although I've never experienced this).
@rmichalak rmichalak added the bug An unexpected problem or unintended behavior of an add-on label Dec 1, 2024
@rmichalak rmichalak linked a pull request Dec 1, 2024 that will close this issue
Open
@jlaur jlaur linked a pull request Dec 8, 2024 that will close this issue
Open
@jlaur
Copy link
Contributor

jlaur commented Dec 8, 2024

Receiver thread is only protected against IOException (here) but sometimes (due to random communication issues), a different kind of exception can occur in which case the thing is not properly reinitialized (via handleCommunicationError) and the thread stops which means the communication with the alarm system is lost.

I'm suspecting that it's NumberFormatException and IndexOutOfBoundsException being thrown by DigiplexResponseResolver. I had a closer look yesterday - see #17864. I don't see any obvious other places where RuntimeExceptions could be thrown.

Same thing can potentially happen in the sender thread (although I've never experienced this).

I don't think so for the reason above, which is probably why you never experienced it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
2 participants
@rmichalak @jlaur