Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does utils.timeseries_HiTRes do the same thing as ModelScenario._calc_modelled_obs_HiTRes? #78

Open
brendan-m-murphy opened this issue Feb 12, 2024 · 2 comments
Open

Does utils.timeseries_HiTRes do the same thing as ModelScenario._calc_modelled_obs_HiTRes? #78

brendan-m-murphy opened this issue Feb 12, 2024 · 2 comments
Labels
legacy code

Comments

@brendan-m-murphy
Copy link
Contributor

This code seems to be repeated in both openghg and openghg inversions. It might be worth comparing it to the ACRG code.
@brendan-m-murphy
Copy link
Contributor Author

The function timeseries_HiTRes hasn't been modified since it was added to inversions, so presumably it is the same as the version in the ACRG repo.

@brendan-m-murphy
Copy link
Contributor Author

...they are not exactly the same: the ACRG code is split over two functions: timeseries_HiTRes_setup and timeseries_HiTRes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
legacy code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brendan-m-murphy