Fix global crs codes lookup in discovery collections crs tests #255
+471
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscoveryCollectionsDefaultCrs asserts that a `/collections` document complies with ``` Abstract Test 2: /conf/crs/default-crs Test Purpose: Verify that the list of supported CRSs includes the default CRS. Requirement: /req/crs/fc-md-crs-list B ``` but doesn't expand the collection's `#/crs` JSON pointer to the collections document crs list. This patch fixes it and adds unit tests to cover all possible cases.
DiscoveryCollectionsStorageCrs asserts that a `/collections` document
complies with
```
Abstract Test 3: /conf/crs/storageCrs
Test Purpose: Verify that the storage CRS identifier is a valid value
Test Method: For each collection object that includes a storageCrs property in the paths /collections and
/collections/{collectionId}, validate that the string is also found in the crs property of the collection or, in case
the crs property includes a value #/crs, in the global list of CRSs.
```
but doesn't expand the collection's `#/crs` JSON pointer to the collections
document crs list.
This patch fixes it and adds unit tests to cover all possible cases.
groldan
added a commit
to groldan/geoserver
that referenced
this pull request
Nov 17, 2024
…nal fixes Use a patched version of `ogccite/ets-ogcapi-features10:1.8-SNAPSHOT-teamengine-5.4.1`. Currently, we require the following pull request to be applied: [Fix global crs codes lookup in discovery collections crs tests](opengeospatial/ets-ogcapi-features10#255) to the test suite. This may happen again, hence we're introducing a build step to generate the required `ogccite/ets-ogcapi-features10` image out of the `geoserver/ets-ogcapi-features10` fork, using a branch named `geoserver/integration`. The procedure to maintain that branch is to rebase on top of the upstream master branch as required, and apply the additional branches with `git merge --no-ff`.
11 tasks
groldan
added a commit
to groldan/geoserver
that referenced
this pull request
Nov 17, 2024
…nal fixes Use a patched version of `ogccite/ets-ogcapi-features10:1.8-SNAPSHOT-teamengine-5.4.1`. Currently, we require the following pull request to be applied: [Fix global crs codes lookup in discovery collections crs tests](opengeospatial/ets-ogcapi-features10#255) to the test suite. This may happen again, hence we're introducing a build step to generate the required `ogccite/ets-ogcapi-features10` image out of the `geoserver/ets-ogcapi-features10` fork, using a branch named `geoserver/integration`. The procedure to maintain that branch is to rebase on top of the upstream master branch as required, and apply the additional branches with `git merge --no-ff`.
bpross-52n
approved these changes
Nov 22, 2024
|
@bpross-52n I can't merge pull requests on this repo. Would you merge it for me please? |
|
@groldan Sure, don't worry, we are taking care of it. This is usually done when we prepare the next Beta release. |
|
Thanks a lot, I wasn't sure what the procedure was. |
groldan
added a commit
to groldan/geoserver
that referenced
this pull request
Nov 27, 2024
Revert to build the `ogccite/ets-ogcapi-features10:1.8-SNAPSHOT-teamengine-5.4.1` docker image for ogcapi-features CITE testing from the official repository's `master` branch now that the [requried fix](opengeospatial/ets-ogcapi-features10#255) is merged.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
DiscoveryCollectionsStorageCrslook up of global crsDiscoveryCollectionsStorageCrsasserts that a/collectionsdocument complies withbut doesn't expand the collection's
#/crsJSON pointer to the collections document crs list.This patch fixes it and adds unit tests to cover all possible cases.
Fix
DiscoveryCollectionsDefaultCrslook up of codes in the global crsDiscoveryCollectionsDefaultCrsasserts that a/collectionsdocument complies withbut doesn't expand the collection's
#/crsJSON pointer to the collections document crs list.This patch fixes it and adds unit tests to cover all possible cases.
Fixes #251