Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing report of missing datetime parameter as time rather than datetime #132

Closed
jerstlouis opened this issue Jan 21, 2021 · 6 comments · Fixed by #136
Closed

Confusing report of missing datetime parameter as time rather than datetime #132

jerstlouis opened this issue Jan 21, 2021 · 6 comments · Fixed by #136
Assignees
Milestone

Comments

@jerstlouis
Copy link
Member

When the datetime query parameter on /items is missing, this is confusingly being reported as the "time" query parameter missing. (the requirement is called /req/core/fc-time-definition, even though the parameter is datetime)
The Abstract test cited is also not aligned with the latest standard as it reports Abstract Test 14 but this is currently Abstract Test 18.

@dstenger
Copy link
Contributor

Thank you for reporting.

@keshav-nangare Can you please adjust the test to the latest version of the standard?

@keshavnangare
Copy link

@dstenger

I have updated the test description as per the latest version of the standard and error message. Please find the changes in #136 PR.

@dstenger
Copy link
Contributor

dstenger commented Feb 4, 2021

@keshav-nangare Can you please also update the numbers of referenced abstract tests for all tests? Please use the ATS of the specification for that: http://docs.opengeospatial.org/is/17-069r3/17-069r3.html#_abstract_test_suite_normative

@keshavnangare
Copy link

I have updated the description of tests according to the document referred in the above comment. Please find the changes in the same PR.

@keshavnangare
Copy link

Following tests are not have implemented:

  1. Abstract Test 2
  2. Abstract Test 15 (Partial implemented)
  3. Abstract Test 22 (Method 3 and 8)
  4. Abstract Test 30-43

@dstenger
Copy link
Contributor

dstenger commented Mar 1, 2021

Abstract Test 2 -> Covered by #140
Abstract Test 15 (Partial implemented) -> Covered by #18
Abstract Test 22 (Method 3 and 8) -> Covered by #142
Abstract Test 30-43 -> Covered by #97, #98, #99, #100 and #101

@dstenger dstenger added this to the 1.2 milestone Mar 2, 2021
@dstenger dstenger added this to CITE Aug 1, 2024
@dstenger dstenger moved this to Done in CITE Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants