-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Shared common scanner #3883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📈 Analytics
We use Sentry and Matomo, with an opt-in system
dependencies
🤳🥫 Scan
We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
🧪 Tests
🤳 ZXing
labels
Apr 17, 2023
monsieurtanuki
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M123-dev, looks good to me!
I have minor comments; feel free to ignore them.
And let's go to the next step!
github-actions
bot
added
🤗 Onboarding
We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
🥫 Product page
User lists
labels
Apr 18, 2023
Thanks for your review @monsieurtanuki, good things you mentioned. I've applied your suggestions :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📈 Analytics
We use Sentry and Matomo, with an opt-in system
dependencies
🤗 Onboarding
We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
🥫 Product page
🤳🥫 Scan
We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
🧪 Tests
User lists
🤳 ZXing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We had to get to the old state of the continuous delivery pipeline to allow to build a dedicated F-Droid build without non open source parts, namely ML Kit. To be able to build them I had to extract ZXing and ML Kit in theire own packages which we have as dependencies in smoothie. As they are only used in the entry point and in no other file the build still works when commenting out the not used scanner.
Automating this will be done in the next PR.
To be able to share the scanner around in the code, I created a new shared scanner interface.
Part of