Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Separated Welcome to with Open food Facts #1417

Closed
wants to merge 1 commit into from
Closed

fix: Separated Welcome to with Open food Facts #1417

wants to merge 1 commit into from

Conversation

abhay1821
Copy link
Contributor

What

  • This PR includes the fix of Separating Welcome to with Open Food Facts

Screenshot

After Fixed

Fixes bug(s)

Part of

@abhay1821 abhay1821 requested a review from a team as a code owner March 30, 2022 13:02
@abhay1821
Copy link
Contributor Author

Hi @M123-dev,
can you please review it and give input on this I tried using "Welcome to Open\u00A0Food\u00A0Facts" but it didn't Helped much

@teolemon teolemon added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Mar 30, 2022
@teolemon teolemon linked an issue Mar 30, 2022 that may be closed by this pull request
Can we ensure Open Food Facts is never cut into 2 parts (carriage return before Open) ? #1405
Closed
@M123-dev
Copy link
Member

Cc: @monsieurtanuki

@monsieurtanuki
Copy link
Contributor

Actually done in #1421.

1 similar comment
@monsieurtanuki
Copy link
Contributor

Actually done in #1421.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we ensure Open Food Facts is never cut into 2 parts (carriage return before Open) ?
4 participants
@abhay1821 @M123-dev @monsieurtanuki @teolemon