The scanner should display a snackbar "Not a valid product barcode" when we scan a QR-Code

[teolemon]

What

• add just a snackbar "Not a valid product barcode" when we scan a QR-Code

Old discussion

• Decide what we do when we scan a QR-Code
• I tried to add it. And now, I have a grey screen in lieu of History again.
• Do we fail silently ? Do we say "Please scan the barcode instead, or if there's no barcode on the packaging, click the button below to open the URL in a web browser" ?

Screenshot

Part of

• 🤳🥫 Scanning (tracker) #526

[monsieurtanuki]

Different answers:

• should we accept QR code? I don't think so. Probably a matter of set up in the scan library.
• does it also crash when it's an unknown barcode?

[monsieurtanuki]

Suggested fix:

  Future<void> onScan(final Barcode barcode) async {
    if (barcode.code == null) {
      return;
    }
    if (barcode.format != BarcodeFormat.ean13) { // just added a check on the format
      return;
    }
    final String code = barcode.code!;
    if (_barcodeTrustCheck != code) {
      _barcodeTrustCheck = code;
      return;
    }
    if (_latestScannedBarcode == code) {
      return;
    }
    _latestScannedBarcode = code;
    _addBarcode(code);
  }

[M123-dev]

should we accept QR code? I don't think so. Probably a matter of set up in the scan library.

It is probably not difficult to add another qr_code_card which is just a bit more compfort for the user, everything is better then just showing nothing if we scan barcodes non the less

[M123-dev]

Also we could call UrlLauncher.canLaunch and if true even allow to open the barcode link

[VaiTon]

Also we could call UrlLauncher.canLaunch and if true even allow to open the barcode link

I don't think that's good for user security. There are app to open QR codes and we're not one of them.

It is probably not difficult to add another qr_code_card which is just a bit more compfort for the user, everything is better then just showing nothing if we scan barcodes non the less

Maybe we could add just a snackbar "Not a valid product barcode".

[teolemon]

I'm ok with that solution. Renaming the bug accordingly

[teolemon]

@mse-moises What about this one ?

[mse-moises]

Sure, assign me and I'll start working on it after I finish the one that i doing right now.

[VaiTon]

@mse-moises any news on this one?

[mse-moises]

@VaiTon In the pull request #1739, the team came to the conclusion that it was no longer needed.

[M123-dev]

I think the implementation of not accepting qr codes was no londer needes as @g123k did a lot of refactoring and included this. I'd say a snackbar still makes sense

[g123k]

Indeed, we don't detect Qr codes anymore. So we can't know if it is a Qr code or not 🤪

[VaiTon]

Indeed, we don't detect Qr codes anymore. So we can't know if it is a Qr code or not 🤪

Ok, so we only detect valid barcodes? If that is true we can close this! @g123k