Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause camera feed after inactivity #2199

Closed
g123k opened this issue Jun 7, 2022 · 5 comments · Fixed by #2229
Closed

Pause camera feed after inactivity #2199

g123k opened this issue Jun 7, 2022 · 5 comments · Fixed by #2229
Assignees
Labels
camera 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…

Comments

@g123k
Copy link
Collaborator

g123k commented Jun 7, 2022

What

Hi everyone,

@alexgarel suggests me an interesting feature to lower the battery usage.

Imagine your phone has a display timeout of 5 min. If you stay on the Smoothie homepage, it will compute for 5 min.

An automatic pause feature (let's say 1min) would be nice if the user stays on the homepage, without any scan.

It's also really simple to implement.

Part of

@teolemon teolemon added 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… camera labels Jun 7, 2022
@VaiTon
Copy link
Member

VaiTon commented Jun 7, 2022

Maybe in that case we could replace the overlay with a button saying "Scanner paused. Press anywhere to resume."

@g123k
Copy link
Collaborator Author

g123k commented Jun 8, 2022

My idea was even more intrusive with a dialog saying: "To optimize the battery life of your phone, the scanner has been automatically turned off after 1 min of inactivity". Two buttons -> restart scanner / keep the scanner paused.

For the second option, the visor is replaced by your suggestion @VaiTon

@VaiTon
Copy link
Member

VaiTon commented Jun 8, 2022

My idea was even more intrusive with a dialog saying: "To optimize the battery life of your phone, the scanner has been automatically turned off after 1 min of inactivity". Two buttons -> restart scanner / keep the scanner paused.

For the second option, the visor is replaced by your suggestion @VaiTon

I really like it @g123k !

@g123k g123k self-assigned this Jun 8, 2022
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 9, 2022
@g123k g123k reopened this Jun 9, 2022
@g123k g123k moved this from Done to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 19, 2022
@g123k g123k modified the milestone: V1.1 Jun 19, 2022
@teolemon teolemon moved this from Todo (ready 2 dev) to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 16, 2022
@teolemon
Copy link
Member

I'm not completely sure it's a good idea, given the confusion around black screens.

@g123k
Copy link
Collaborator Author

g123k commented Aug 30, 2022

Ok, let's close the issue for now.
But the idea to pause the feed is to show a paused screenshot, not a black screen.

@g123k g123k closed this as completed Aug 30, 2022
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
camera 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging a pull request may close this issue.

3 participants