Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Mode: setting to change the post frame callback duration #1764

Closed
g123k opened this issue May 6, 2022 · 4 comments · Fixed by #1766
Closed

Dev Mode: setting to change the post frame callback duration #1764

g123k opened this issue May 6, 2022 · 4 comments · Fixed by #1766
Assignees
Labels
dev mode 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…

Comments

@g123k
Copy link
Collaborator

g123k commented May 6, 2022

Following the PR #1732, a timeout is set to detect if we have to relaunch the camera.
In some cases, it seems that this duration is not enough.

To find a correct value, a setting in the dev mode would be nice

@g123k g123k self-assigned this May 6, 2022
@monsieurtanuki
Copy link
Contributor

@g123k Beyond setting a decent minimum duration, are you sure there are no other ways to detect "the right moment"? Like somme callback, some event?

Not 100% related: would that be possible to limit the camera to the top half of the screen? I mean, not just processing rather the top part, but using a camera viewer Widget whose height is only half of the screen height? That would be less to process, and anyway the bottom half of the screen is already occupied.

@g123k
Copy link
Collaborator Author

g123k commented May 6, 2022

@monsieurtanuki I don't think we can do it otherwise, unfortunately.
I have tried many ways to detect the event and that's the most accurate I've found.

For the camera, it won't change anything (or at least, only be marginal), as the stream sent from the camera is exactly the same.

@monsieurtanuki
Copy link
Contributor

Maybe all these problems come from the fact that we're virtually displaying 3 pages while hiding 2 of them. Things would perhaps be easier if the scan page was a normal page users go to and go back to. Thinking out loud.

@teolemon teolemon added dev mode 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels May 6, 2022
@g123k
Copy link
Collaborator Author

g123k commented May 6, 2022

Actually we have "one real" visible Widget and two hidden (via an Offstage).
We can fully remove them, but will mean we will have to manage the state.

I will experiment this, as part of #1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev mode 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging a pull request may close this issue.

3 participants