Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanning abnormal behavior when multiple barcodes in view #1630

Closed
vik4114 opened this issue Apr 23, 2022 · 2 comments
Closed

Scanning abnormal behavior when multiple barcodes in view #1630

vik4114 opened this issue Apr 23, 2022 · 2 comments
Labels
🎯 P1 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Milestone
V1.1

Comments

@vik4114
Copy link
Contributor

vik4114 commented Apr 23, 2022

What

  • If there are multiple barcodes in view then they all get scanned sometimes and sometimes none get scanned

Steps to reproduce the behavior

  1. Go to Scanning
  2. Scan multiple barcodes in view
  3. See error

Expected behavior

Only barcode in the focused area should get scanned.

Why

Otherwise mis-scan will happen of undesired product ( one example could be scanning in grocery shelves where there will be multiple products)

Video

WhatsApp.Video.2022-04-23.at.2.59.40.PM.mp4

Smartphone model

  • Device: Redmi note 8 pro
  • OS: Android 11
@teolemon teolemon added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Apr 26, 2022
@monsieurtanuki
Copy link
Contributor

Would probably be fixed by #1582 and top-half mode: scanning only the top half of the screen (and no crash on iOS).

@teolemon teolemon added this to the V1 milestone Apr 27, 2022
@M123-dev M123-dev added P4 and removed 🎯 P1 labels Jun 8, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Jun 18, 2022
@teolemon teolemon mentioned this issue Jul 7, 2022
Closed
5 tasks
@teolemon teolemon added 🎯 P1 and removed P4 labels Aug 20, 2022
@g123k
Copy link
Collaborator

g123k commented Sep 15, 2022

That's fixed with the current implementation where we filter only barcodes on top of the app.
But in the case, where we have multiples barcodes, it's supported

@g123k g123k closed this as completed Sep 15, 2022
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎯 P1 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1.1
Development

No branches or pull requests
6 participants
@g123k @teolemon @monsieurtanuki @M123-dev @vik4114 @olivierdrouard