Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying obsolete products through openfoodfacts-query #9134

Closed
stephanegigandet opened this issue Oct 10, 2023 · 1 comment · Fixed by #9228
Closed

Querying obsolete products through openfoodfacts-query #9134

stephanegigandet opened this issue Oct 10, 2023 · 1 comment · Fixed by #9228
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🗄 Obsolete products

Comments

@stephanegigandet
Copy link
Contributor

It's possible to get lists of obsolete products by adding ?obsolete=1 to URLs. In that case we issue query on the products_obsolete collection.

e.g. to see brands for which we have products marked obsolete: https://world.openfoodfacts.org/brands?obsolete=1

This behavior does not seem to be implemented with the openfoodfacts-query service.

@stephanegigandet stephanegigandet added the 🐛 bug This is a bug, not a feature request. label Oct 10, 2023
@john-gom
Copy link
Contributor

I've raised PR #9 on openfoodfacts-query to handle this. Will raise a separate PR on off-server to supply the obsolete tag when this is in the request.
In the same PR I'll remove the code that falls back to product_tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🗄 Obsolete products
Projects
Development

Successfully merging a pull request may close this issue.

3 participants