feat: Add support for new stream name #113
Merged
+177
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Gomersall <[email protected]>
| id: lastMessageId, | ||
| }, | ||
| // Following can be deleted after PO is updated to use generic stream name | ||
| // Note should strictly have a different message id but PO will take more than one millisecond to switch |
There was a problem hiding this comment.
We won't switch all 4 flavors at the exact same time, hopefully it won't be an issue as the non food products will be ignored anyway.
There was a problem hiding this comment.
This was more because PO will switch from using the product_updates_off stream to product_updates. In theory the message id is only unique per stream, but it is prefixed with the time in milliseconds so using the same "last" message id to track the transition shouldn't be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Gomersall [email protected]
What
Addresses