Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dart language template #94

Open
pmundt opened this issue Sep 16, 2019 · 8 comments
Open

Add support for Dart language template #94

pmundt opened this issue Sep 16, 2019 · 8 comments

Comments

@pmundt
Copy link

pmundt commented Sep 16, 2019

In experimenting with OpenFaaS, the lack of a Dart runtime created some difficulties for me during evaluation, so I've gone ahead and written one:

@alexellis
Copy link
Member

Thanks for this submission.

RUN pub get
RUN pub get --offline

I would suggest running these two commands with && to reduce layering.

@alexellis
Copy link
Member

Can you edit the README to say: Dart Template for OpenFaaS?

@alexellis
Copy link
Member

After that I think we can accept a PR for the template store 👍

Checkout the instructions in README.md and send it over

@alexellis
Copy link
Member

@pmundt do you still want this, or should we close the issue?

@pmundt
Copy link
Author

pmundt commented Oct 28, 2019

@alexellis Thank you for the feedback, I'll implement your suggestions and open up a PR as per the README instructions - unfortunately I don't think I'll have time to get back to this for a few days, as I'll be at a conference for most of this week.

@pmundt
Copy link
Author

pmundt commented Dec 16, 2019

@alexellis any update on this? Would be good to get this ticked off and to close PR #107

@alexellis
Copy link
Member

The last update I see from you was this:

unfortunately I don't think I'll have time to get back to this

I didn't hear from you since then, but I see you have a PR up now. It'll get prioritised along with everyone else's PRs 👍

@alexellis
Copy link
Member

Please see the detailed comments on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants