-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LSB Steganography function #80
Conversation
This function is capable of Encoding and Decoding using LSB Steganography Fixes openfaas#79 Signed-off-by: Rafael Passos <[email protected]>
I think I understand the function now, but I don't think the user journey is good enough in the Portal to merge this right now. There are several other functions with complex inputs beyond a URL where the experience is poor. We need a help text to be displayed in the UI, at the very least a link out to the originating repo's README. cc @burtonr |
I agree. I plan to get some more work done to this function in the future ( I'm unavailable at the moment). Besides changing the function, I see two ways that the Portal could be improved to make complex functions more available:
Shall we discuss this in Slack ? |
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: auyer <[email protected]>
Having a clear-up on GitHub issues / PRs over 1 month old. Let's revisit as necessary. Thank you for the PR. |
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Auyer <[email protected]>
Hi @alexellis , I just re-visited this function.
Its working fine, and its usable once the user reads the quite simple README.md (witch is necessary to use most functions anyway) |
@auyer the latest master of your function is not passing CI, perhaps we want to get that fixed first |
Wow I changed the job name and forgot to change it in the workflow. |
This function is capable of Encoding and Decoding using LSB Steganography
Fixes #79
Signed-off-by: Rafael Passos [email protected]