-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openfaas ingress operator chart #666
Conversation
Signed-off-by: Vivek Singh <[email protected]>
322ea94
to
16fba2c
Compare
|
||
- Install OpenFaaS | ||
|
||
You must have a working OpenFaaS installation. You can find [instructions in the docs](https://docs.openfaas.com/deployment/kubernetes/#pick-helm-or-yaml-files-for-deployment-a-or-b), including instructions to also install OpenFaaS via Helm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ID of this section has changed to '#pick-arkade-helm-or-plain-yaml-files
@@ -1,5 +1,4 @@ | |||
{{- $functionNs := default .Release.Namespace .Values.functionNamespace }} | |||
{{- if .Values.ingressOperator.create }} | |||
{{- if .Values.create }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we always want to create these things now it's in it's own chart? (few files with this in)
|
||
replicas: 1 | ||
|
||
create: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't we want to get rid of this value as this is explicitly True when installing this now
Didn't this happen @viveksyngh ? |
I think this one was for migrating ingress operator to it's own helm chart. |
We did this separately a while back so I'm closing the PR. |
/lock |
This removes ingress operator from the openfaas helm chart and adds a new helm chart for the ingress operator
Description
Motivation and Context
#664
How Has This Been Tested?
I have tested this on Digital Ocean Kubernetes cluster
Types of changes
Checklist:
git commit -s