Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple requests in parallel #9

Open
levino opened this issue Apr 8, 2017 · 1 comment
Open

Multiple requests in parallel #9

levino opened this issue Apr 8, 2017 · 1 comment

Comments

@levino
Copy link

levino commented Apr 8, 2017

This library is weird. Why do you store the rates in a kinda global variable? What happens if I query multiple times for multiple dates. One has to implement a kind of global queue just because this library is poorly implemented. oxr.historical should not store the rates to the oxr object but pass it into the callback as an argument. Also what about error handling?
@levino
Copy link
Author

levino commented Aug 16, 2018

This library is unmaintained and not well implemented. I use https://github.com/continuous-software/oxr#historicaldate-query-options now.

@webdevian webdevian mentioned this issue Apr 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@levino