-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting upstream branch tracking info #116
Comments
PS: @borpin im sure you will be happy with the new stable branches. Im thinking of adding a feature to select stable, master or auto from the emoncms UI to make switching between stable/master on a global level easier. |
On changing from UI - great! I was thinking of an advanced update page that would allow a per repo brach selection option. Not come across this problem with git. Can't try till Sunday. Can you tell me what you tried that failed? Did you try a Might be how the initial clone was done in the past. Is it a problem on a fresh scripted install? |
Thanks @borpin yes I tried git fetch -all, not quite sure why that didnt work. Im also away until Sunday now. Will reply with more detail then. |
So I have just had a go on an emonpi setup, created by the script (I think) a while back. I've included a screenshot as the colour helps explain things. TL:DR The oddity is that it talks about a 'new' branch, but I don't think it really means that, rather that it has created a new local branch that is tracking a remote branch (if you see what I mean).
Finally this looks correct.
I will do the same for the postprocess folder...
|
As an aside, could you update all of the |
updated version: emoncms/emoncms@b925f6e |
I previously updated the versions for the other modules e.g: emoncms/sync@39361e4 just somehow forgot the main repo |
If I run git fetch and then git checkout it gives me this message, so looks like git pull is required.
|
It was other modules I found - Emoncms/device has the same version for master & stable. I see you updated WiFi a few minutes ago but left off the 'beta' 😀. |
Use the Yes, I think it will. I couldn't test that as stable and master were the same! |
I think it is partly because the original clone targets a specific branch. |
Yes I don’t want to add the beta to all modules, I think we just keep to updating the version on the module master branches after making a change and then merge to stable when ready. |
prune command is already in there:
|
Ok but it then will get really confusing when looking at current state of Modules. At least a 'b' would immediately identify that the Module was pulled from master as opposed to stable. |
I was thinking that we need to attach the branch to the version in the module list. That would be a good thing to add alongside the ability to change between stable/master on a global level via the UI. |
Can do. Could also make it clearer what are 'core' and what are 'addons'. One per line, perhaps hold a 'manifest' type file that lists all modules available and then the version number if installed in the UI. Perhaps:
TBH I would not list the core modules, just the add-ons. |
yes I think that would be really nice and I agree better without core modules, just the add-ons |
In attempting to automate the switching of the postprocess, device and sync modules to newly created stable branches I came across an issue caused by for some reason certain repositories not having upstream branch tracking info set. This meant I could not pull in all branches and switch to the newly created stable branches.
The solution I found to work was the following:
https://github.com/openenergymonitor/emonpi/compare/923e05deeb9ea5945b5493c665f21a20f6be182c..master
I needed to run:
and then:
without the branch specific pull, it was then possible to run:
@borpin what do you think of this solution? Its a shame to pollute every emonpiupdate log with:
but it does seem to work well.
The text was updated successfully, but these errors were encountered: