Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we converge on one set up official upstream images? #38

Open
Tracked by #167
kdmccormick opened this issue Jan 27, 2022 · 2 comments
Open
Tracked by #167

Can we converge on one set up official upstream images? #38

kdmccormick opened this issue Jan 27, 2022 · 2 comments
Labels
discovery Pre-work to determine if an idea is feasible tutor Requires a change to Tutor

Comments

@kdmccormick
Copy link
Member

There are at least three sets of Open edX docker images:

  1. The Ansible-based ones under edxops/ that devstack uses,
  2. The in-repo-Dockerfile ones under openedx/ that nothing uses, and
  3. The ones built by Tutor and its plugins.

Set 1 could be dropped after Devstack deprecation & removal.

Could we drop Set 2, and make Set 3 the "official" set of Docker images? Would it make sense to host/mirror them under the openedx/ DockerHub org?

@regisb
Copy link
Contributor

regisb commented Feb 1, 2022

I am not aware of any application that uses the images from the in-repo Dockerfiles. The initial ambition was that they would replace the images in the Devstack, but that didn't work. You were the last one to make changes to edx-platform/Dockerfile, so I guess that you know more about it.

In the long run, Tutor could probably make use of the upstream images. But for that to happen there needs to be a deliberate effort to create, test and maintain these images. My impression is that the Dockerfiles were created with the hope that they would be properly maintained, but they are not because they are not part of anyone's workflow -- I might be wrong here of course, because I don't know if there are people actually using these images.

Thus I agree that the Dockerfiles should be removed, because they might create confusion and do not serve any particular purpose.

Would it make sense to host/mirror them under the openedx/ DockerHub org?

From my perspective, the organization that hosts a project is also tasked with its maintenance. ("great powers, great responsibilities") So I'm perfectly fine with 2U hosting mirror images, but I don't want to pull images from a different org.

For the record, pushing images to a different org is done quite easily with:

tutor config save --set DOCKER_IMAGE_OPENEDX='2u/openedx:{{ TUTOR_VERSION }}'
tutor images build openedx
tutor images push openedx

@kdmccormick kdmccormick changed the title As a maintainer of Open edX, I want there to be one official set of base Docker images Can we converge on one set up official upstream images? Nov 18, 2022
@kdmccormick kdmccormick added the discovery Pre-work to determine if an idea is feasible label Nov 18, 2022
@kdmccormick kdmccormick transferred this issue from openedx-unsupported/wg-developer-experience Mar 28, 2024
@kdmccormick kdmccormick added the tutor Requires a change to Tutor label Mar 28, 2024
@kdmccormick
Copy link
Member Author

This is potentially solved by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Pre-work to determine if an idea is feasible tutor Requires a change to Tutor
Projects
No open projects
Development

No branches or pull requests

2 participants